Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pillow] Removed python symlink #12326

Merged
merged 2 commits into from
Aug 27, 2024
Merged

[Pillow] Removed python symlink #12326

merged 2 commits into from
Aug 27, 2024

Conversation

radarhere
Copy link
Contributor

Pillow's oss-fuzz is currently failing, because Pillow main has dropped support for Python 3.8.

#12027 attempts to resolve this by upgrading the base builder to Python 3.10, but the latest status update over there says that Pillow fails in that branch with

Step 17: Step 6/11 : RUN ln -s /usr/local/bin/python3 /usr/local/bin/python && ln -s /bin/true /usr/local/bin/yum_install && ln -s /bin/true /usr/local/bin/yum && cd $SRC/Pillow && git submodule update --init wheels/multibuild && bash $SRC/build_depends.sh
Step 17: ---> Running in 932abd1dc89a
Step 17: �[91mln: failed to create symbolic link '/usr/local/bin/python': File exists

So this pull request removes the python symlink in order to try and help.

cc @hugovk

Copy link

radarhere has previously contributed to projects/pillow. The previous PR was #11267

@radarhere
Copy link
Contributor Author

https://github.com/google/oss-fuzz/actions/runs/10331059544/job/28600812260?pr=12326#step:6:12

Changed files: projects/pillow/Dockerfile
Please add an "apt-get update" before "apt-get install". Otherwise, a cached and outdated RUN layer may lead to install failures.
Failed.

Hmm. I would have thought that is what is happening?

@DaveLak
Copy link
Contributor

DaveLak commented Aug 10, 2024

Hmm. I would have thought that is what is happening?

@radarhere I think that check is failing because of the install at the bottom of the file:

https://github.com/radarhere/oss-fuzz/blob/7832cf88a3085810ed2389183b85e42e68a2fc3e/projects/pillow/Dockerfile#L46


Also, thanks for investigating the failure in #12027!

Out of curiosity, did the changes here work for you locally?

Part of the changes I propose in that PR are aliasing the python3 and python executables in the base images and last I checked, only python3 was available in the currently deployed images.

If it turns out that this does depends on the unmerged changes:

I've been collecting patches that will be required after a Python 3.10 upgrade on a per broken project basis here: master...DaveLak:oss-fuzz:update-projects-after-python-10-upgrade and that includes Pillow's, dcd020c

@radarhere
Copy link
Contributor Author

@radarhere I think that check is failing because of the install at the bottom of the file:

https://github.com/radarhere/oss-fuzz/blob/7832cf88a3085810ed2389183b85e42e68a2fc3e/projects/pillow/Dockerfile#L46

You're right, thanks - I've pushed a commit, and presubmit checks are satisfied now.

@DonggeLiu
Copy link
Contributor

I reckon the CI failed due to incompatible python version?

ERROR: Package 'pillow' requires a different Python: 3.8.3 not in '>=3.9'
ERROR:__main__:Building fuzzers failed.

@radarhere
Copy link
Contributor Author

Pillow dropped support for Python 3.8, so the error is already happening in master.

This PR isn't intended to fix Pillow's oss-fuzz completely, merely to try and help the final solution of #12027.

@DonggeLiu
Copy link
Contributor

Yep, I will merge, then

@DonggeLiu DonggeLiu merged commit b16e5bc into google:master Aug 27, 2024
12 of 15 checks passed
@radarhere radarhere deleted the pillow branch August 27, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants